Skip to content

dronecan: esc: UAVCAN_ESC_IFACE default to CAN2 only#25504

Closed
dakejahl wants to merge 2 commits intomainfrom
pr-uavcan_esc_mask
Closed

dronecan: esc: UAVCAN_ESC_IFACE default to CAN2 only#25504
dakejahl wants to merge 2 commits intomainfrom
pr-uavcan_esc_mask

Conversation

@dakejahl
Copy link
Copy Markdown
Contributor

Solved Problem

UAVCAN_ESC_IFACE parameter to select the CAN bus for outputting ESC data was added in #24922

Solution

Default UAVCAN_ESC_IFACE to CAN2

Changelog Entry

For release notes:

dronecan: esc: UAVCAN_ESC_IFACE default to CAN2 only

@niklaut
Copy link
Copy Markdown
Contributor

niklaut commented Sep 1, 2025

I completely agree with this, but it's not backward compatible, that's why I used the full mask 0xff.

@dakejahl
Copy link
Copy Markdown
Contributor Author

dakejahl commented Sep 1, 2025

I don't think we have ever cared about maintaining backwards compatibility in master. Maybe I'm wrong, but otherwise we'd never be able to move forward. I can see the issue though -- a user updates from 1.16 to 1.17 and now their escs don't work. To draw a comparison, between 1.15 and 1.16 we split the RC protocols out of rc_input and into per-protocol drivers and set all protocols to default disabled. This has resulted in many users reporting "rc doesn't work". It was a necessary breaking change, but it caused users pain. For manufacturers this can be solved in the airframe file using PARAM_DEFAULTS_VER
https://docs.px4.io/main/en/dev_airframes/adding_a_new_frame.html#force-reset-of-airframe-parameters-on-update

@AlexKlimaj
Copy link
Copy Markdown
Member

For boards that don't have a CAN2 interface, we should add a board param default to the CAN interface it has, ie CAN1.

@github-actions
Copy link
Copy Markdown

No flaws found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants