dronecan: esc: UAVCAN_ESC_IFACE default to CAN2 only#25504
dronecan: esc: UAVCAN_ESC_IFACE default to CAN2 only#25504
Conversation
|
I completely agree with this, but it's not backward compatible, that's why I used the full mask 0xff. |
|
I don't think we have ever cared about maintaining backwards compatibility in master. Maybe I'm wrong, but otherwise we'd never be able to move forward. I can see the issue though -- a user updates from 1.16 to 1.17 and now their escs don't work. To draw a comparison, between 1.15 and 1.16 we split the RC protocols out of |
|
For boards that don't have a CAN2 interface, we should add a board param default to the CAN interface it has, ie CAN1. |
62a95a8 to
15fab5c
Compare
|
No flaws found |
Solved Problem
UAVCAN_ESC_IFACE parameter to select the CAN bus for outputting ESC data was added in #24922
Solution
Default UAVCAN_ESC_IFACE to CAN2
Changelog Entry
For release notes: